Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy dataset mako #17507

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Feb 20, 2024

This PR removes the copy dataset controller endpoint and mako. User can copy datasets between histories using the history multi view. Additionally the legacy interface does not scale well for medium to large histories.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/backend labels Feb 20, 2024
@guerler guerler added this to the 24.0 milestone Feb 20, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Feb 20, 2024

It is still by far the fastest way to copy multiple datasets. Admittedly I didn't even know it was still reachable in the UI (the cog wheel options are really not that intuitive). Can we merge this after the 24.0 branch and then make sure there's some kind of replacement (maybe through the side-by-side history view) ?

@jdavcs jdavcs modified the milestones: 24.0, 24.1 Feb 26, 2024
@guerler guerler force-pushed the remove_copy_dataset_mako branch from 16484da to cfa2f98 Compare March 5, 2024 14:58
@guerler guerler marked this pull request as ready for review March 5, 2024 23:02
@guerler guerler force-pushed the remove_copy_dataset_mako branch from cfa2f98 to c1dab96 Compare March 6, 2024 16:25
@guerler guerler force-pushed the remove_copy_dataset_mako branch from c1dab96 to d7f2298 Compare April 2, 2024 06:19
@guerler guerler force-pushed the remove_copy_dataset_mako branch from d7f2298 to 997d1b5 Compare April 11, 2024 07:28
@guerler
Copy link
Contributor Author

guerler commented Apr 11, 2024

@mvdbeek we do have a replacement for this feature now, users can select multiple files in the history and drag/drop them into another history using the multi history view interface thx to @ahmedhamidawan.

@wm75
Copy link
Contributor

wm75 commented Apr 11, 2024

Not only is it still the fastest way as @mvdbeek points out, but I'm also still using this a lot in daily work.
Mostly out of old habits, but, importantly, also on touch screen devices. Last time I checked drag and drop in the multi-history view still wasn't working on mobile and it's that old alternative that saved me then.

I'm not opposed to removing the mako page, but then we need to make sure we have 100% of its functionality available elsewhere.

@guerler guerler marked this pull request as draft April 11, 2024 12:13
@mvdbeek mvdbeek requested a review from dannon May 14, 2024 14:19
@jdavcs jdavcs modified the milestones: 24.1, 24.2 May 20, 2024
@dannon dannon removed their request for review November 15, 2024 14:09
@jdavcs jdavcs modified the milestones: 24.2, 25.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants