-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copy dataset mako #17507
base: dev
Are you sure you want to change the base?
Remove copy dataset mako #17507
Conversation
It is still by far the fastest way to copy multiple datasets. Admittedly I didn't even know it was still reachable in the UI (the cog wheel options are really not that intuitive). Can we merge this after the 24.0 branch and then make sure there's some kind of replacement (maybe through the side-by-side history view) ? |
16484da
to
cfa2f98
Compare
cfa2f98
to
c1dab96
Compare
c1dab96
to
d7f2298
Compare
d7f2298
to
997d1b5
Compare
@mvdbeek we do have a replacement for this feature now, users can select multiple files in the history and drag/drop them into another history using the multi history view interface thx to @ahmedhamidawan. |
Not only is it still the fastest way as @mvdbeek points out, but I'm also still using this a lot in daily work. I'm not opposed to removing the mako page, but then we need to make sure we have 100% of its functionality available elsewhere. |
This PR removes the copy dataset controller endpoint and mako. User can copy datasets between histories using the history multi view. Additionally the legacy interface does not scale well for medium to large histories.
How to test the changes?
(Select all options that apply)
License