-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple drag/drop and keyboard accessible selection to HistoryPanel
items
#17502
Add multiple drag/drop and keyboard accessible selection to HistoryPanel
items
#17502
Conversation
Allow users to select multiple history items with the `Shift + ArrowUp/ArrowDown` keys. Also added keyup events for deleting history items etc.
Also allow dropping multiple histories to create a new history in multiview.
5025693
to
4659f34
Compare
HistoryPanel
itemsHistoryPanel
items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dragging to new history works super well, thanks a lot. I think the keyboard handling though doesn't work for macs ? At least I can't figure out how to select multiple items with the keyboard.
Oh good point, yes working on making this a cross platform thing... |
Merging this now. @ahmedhamidawan I assume the cross-platform fix will be a follow-up. Please feel free to tag it as a bug so we can include it in 24.0. |
While keyboard select was added in galaxyproject#17502 (and polished/fixed) in other PRs, the selector buttons did not allow for Shift+Click selection. This PR adds that.
Two enhancements in this PR:
Multiple item drag/drop:
Allows users to select multiple history items and drag and drop them in places like other histories or even tool forms. Fixes #17509
multi_drag_drop_items.mp4
(there is a
DragGhost
component that indicates how many items you are dragging but not showing up in video)Keyboard navigate and (shift) select history items (and other keyup events):
Allow users to select multiple history items with the
Shift + ArrowUp/ArrowDown
keys. This also allows users to navigate their history items using the arrow keys, currently, we only allow navigating across various buttons for each history item.Also added keyup events for deleting history items etc...
keyboard_navigate_history_items.mp4
How to test the changes?
(Select all options that apply)
License