Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple drag/drop and keyboard accessible selection to HistoryPanel items #17502

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Feb 19, 2024

Two enhancements in this PR:

Multiple item drag/drop:

Allows users to select multiple history items and drag and drop them in places like other histories or even tool forms. Fixes #17509

multi_drag_drop_items.mp4

(there is a DragGhost component that indicates how many items you are dragging but not showing up in video)

Keyboard navigate and (shift) select history items (and other keyup events):

Allow users to select multiple history items with the Shift + ArrowUp/ArrowDown keys. This also allows users to navigate their history items using the arrow keys, currently, we only allow navigating across various buttons for each history item.

Also added keyup events for deleting history items etc...

keyboard_navigate_history_items.mp4

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Allow users to select multiple history items with the `Shift + ArrowUp/ArrowDown` keys.
Also added keyup events for deleting history items etc.
Also allow dropping multiple histories to create a new history in multiview.
@ahmedhamidawan ahmedhamidawan force-pushed the keyboard_select_in_history branch from 5025693 to 4659f34 Compare February 23, 2024 01:03
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review February 23, 2024 01:10
@github-actions github-actions bot added this to the 24.0 milestone Feb 23, 2024
@ahmedhamidawan ahmedhamidawan changed the title Add keyboard accessible selection to HistoryPanel items Add multiple drag/drop and keyboard accessible selection to HistoryPanel items Feb 23, 2024
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dragging to new history works super well, thanks a lot. I think the keyboard handling though doesn't work for macs ? At least I can't figure out how to select multiple items with the keyboard.

@ahmedhamidawan
Copy link
Member Author

ahmedhamidawan commented Feb 27, 2024

The dragging to new history works super well, thanks a lot. I think the keyboard handling though doesn't work for macs ? At least I can't figure out how to select multiple items with the keyboard.

Oh good point, yes working on making this a cross platform thing...

@jdavcs
Copy link
Member

jdavcs commented Mar 1, 2024

Merging this now. @ahmedhamidawan I assume the cross-platform fix will be a follow-up. Please feel free to tag it as a bug so we can include it in 24.0.

@jdavcs jdavcs merged commit ff66f47 into galaxyproject:dev Mar 1, 2024
34 of 35 checks passed
@martenson martenson added the highlight/power-user Included at bottom of user-facing release notes (please use either this or highlight, but not both) label Mar 5, 2024
ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this pull request Mar 15, 2024
While keyboard select was added in galaxyproject#17502 (and polished/fixed) in other PRs, the selector buttons did not allow for Shift+Click selection. This PR adds that.
@jdavcs jdavcs added the highlight Included in user-facing release notes at the top label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX highlight/power-user Included at bottom of user-facing release notes (please use either this or highlight, but not both) highlight Included in user-facing release notes at the top kind/enhancement
Projects
Development

Successfully merging this pull request may close these issues.

Copying multiple history items in side-by-side history view
4 participants