Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable storage management by object store #17500

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Enable storage management by object store #17500

merged 7 commits into from
Mar 28, 2024

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Feb 19, 2024 •
edited
Loading

Starting work on #17447. Screenshots below.

Screenshot 2024-02-19 at 2 46 56 PM
Screenshot 2024-02-19 at 2 47 07 PM
Screenshot 2024-02-19 at 2 47 14 PM

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. setup multiple object stores and look at them in storage management page

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the storage_management branch 7 times, most recently from f7e9b3d to 12af10a Compare February 21, 2024 15:20
@jmchilton jmchilton marked this pull request as ready for review February 28, 2024 15:40
@github-actions github-actions bot added this to the 24.1 milestone Feb 28, 2024
davelopez
davelopez approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I love all the refactoring done here! Thank you so much!

client/src/api/datasets.ts Outdated Show resolved Hide resolved
client/src/components/User/DiskUsage/Visualizations/util.ts Outdated Show resolved Hide resolved
jdavcs
jdavcs reviewed Mar 8, 2024
View reviewed changes
lib/galaxy/model/__init__.py Outdated Show resolved Hide resolved
jdavcs
jdavcs reviewed Mar 8, 2024
View reviewed changes
lib/galaxy/model/__init__.py Outdated Show resolved Hide resolved
@jmchilton jmchilton force-pushed the storage_management branch from 12af10a to f68ca03 Compare March 25, 2024 18:07
@jmchilton jmchilton force-pushed the storage_management branch from f68ca03 to 27c30f0 Compare March 27, 2024 14:26
@jmchilton jmchilton mentioned this pull request Mar 27, 2024
Merged
2 tasks
@jmchilton jmchilton force-pushed the storage_management branch from 27c30f0 to 5bbbd04 Compare March 27, 2024 17:25
davelopez
davelopez approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again for all the nice refactorings!

Test failures seem completely unrelated.

client/src/api/datasets.ts Show resolved Hide resolved
@davelopez davelopez merged commit 99aec81 into galaxyproject:dev Mar 28, 2024
52 of 55 checks passed
@jmchilton jmchilton deleted the storage_management branch March 28, 2024 14:58
@jdavcs jdavcs added highlight Included in user-facing release notes at the top highlight/admin Included in admin/dev release notes labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavcs jdavcs jdavcs left review comments

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/objectstore highlight/admin Included in admin/dev release notes highlight Included in user-facing release notes at the top kind/enhancement
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jmchilton @jdavcs @davelopez