Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotation and refactoring of tests #17484

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Type annotation and refactoring of tests #17484

merged 2 commits into from
Feb 16, 2024

Conversation

nsoranzo
Copy link
Member

See commits for details.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes labels Feb 16, 2024
@github-actions github-actions bot added this to the 24.0 milestone Feb 16, 2024
davelopez
davelopez approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nsoranzo! Looks good!

@nsoranzo nsoranzo merged commit 36f3559 into galaxyproject:dev Feb 16, 2024
54 checks passed
@nsoranzo nsoranzo deleted the type_and_name_fixes branch February 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/testing/integration area/testing kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @davelopez