Remove workflow search from activity bar

[itisAliRH]

Requires: #16607. This PR removes the workflow search from the activity bar.
xref: #16607 (comment)

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

What I was saying in my comment is that the search bar conflicts with the search in the center panel. In no way do I want the workflow activity to be dropped.

[itisAliRH]

What I was saying in my comment is that the search bar conflicts with the search in the center panel. In no way do I want the workflow activity to be dropped.

@mvdbeek Me neither, but the workflow activity without a search bar is used less and duplicates the masthead workflow.
However, #17289 I can implement this one and replace the search fields with favorite/recent workflows (using the ActivityPanel)

[mvdbeek]

I think it is wrong that all activity bar items need a side panel. Also, the workflow activity did not have the side panel on 23.0 and that was perfectly fine. As commented, #17289 is a questionable idea that is unlikely to land in 24.0. Can you please, please, either fix the synchronization of the search or simply drop the search from the side panel.

[mvdbeek]

Thank you, that looks great!

[mvdbeek]

https://github.com/galaxyproject/galaxy/actions/runs/7919456233/job/21623311924?pr=17479#step:11:2337 might be a relevant error ? I've triggered a rerun.

[itisAliRH]

@mvdbeek It passed successfully, thanks. I've cherrypicked this PR changes to the main one and will close it now