data_column parameter: use column_names metadata if present
#17478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
commented
Feb 15, 2024
makes column_parameter work for all datatypes setting column_names and still fallback to try to take the first line (tab separated) fixes: galaxyproject#17468
bernt-matthias
force-pushed
the
topic/column-param-metadata
branch
from
86e1a25 to
2395e65
Compare
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes
data_columnwork for all data types settingcolumn_namesand still fallback to try to take the first line (tab separated). The later is necessary fortabularwhich does not set the column names metadata.fixes: #17468
How to test the changes?
(Select all options that apply)
License