Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds published histories to grid list #17449

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Feb 10, 2024

This PR adds the published history grid to the grid list for consistency. When consolidating the masthead grid tabs, the three history grids i.e. Histories, Shared Histories and Published Histories will appear side by side.

PR also contains a bug fix for the histories manager to avoid responding with duplicate entries.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Feb 10, 2024
@guerler guerler force-pushed the align_published_histories branch 3 times, most recently from ed954c5 to 22cbda7 Compare February 13, 2024 23:02
@guerler guerler added this to the 24.0 milestone Feb 14, 2024
@guerler guerler marked this pull request as ready for review February 14, 2024 15:19
@guerler guerler force-pushed the align_published_histories branch from 22cbda7 to 0a40498 Compare February 15, 2024 15:22
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@ahmedhamidawan ahmedhamidawan merged commit c862527 into galaxyproject:dev Feb 15, 2024
55 checks passed
@guerler guerler deleted the align_published_histories branch February 16, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants