Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix bug: true >> True #17446

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 9, 2024

This was silent because true is a function identifier, so when used in a boolean expression it simply evaluated to True.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs requested a review from assuntad23 February 9, 2024 06:12
@github-actions github-actions bot added this to the 23.0 milestone Feb 9, 2024
@mvdbeek mvdbeek merged commit bed5c5e into galaxyproject:release_23.0 Feb 9, 2024
26 of 37 checks passed
@jdavcs jdavcs deleted the 23.0_truebug branch February 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants