[23.2] Build param dict before creating entrypoint

[mvdbeek]

Fixes #17438.

Thanks for the excellent debugging @cat-bro!

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

@sveinugu does this still make sense to you ? I'm not sure why you moved the entry point creation

[sveinugu]

Right. So it seems there is a circular dependency afoot!

Moving populate_interactivetools() was crucial to allow injection of the interactive tool entry point path to the IT container, which again is crucial to get path-based interactive tools to work in most cases. So one needs to configure the interactive tool entry points before the entry point paths are to be injected to the job as e.g. an environment variable, such as in the following example:

<entry_points>
    <entry_point name="Display name" label="mytool" requires_domain="False" requires_path_in_url="True">
        <port>80</port>
    </entry_point>
</entry_points>

<environment_variables>
    <environment_variable name="EP_PATH" inject="entry_point_path_for_label">mytool</environment_variable>
</environment_variables>

(from https://docs.galaxyproject.org/en/master/admin/special_topics/interactivetools.html).

The only thing this breaks is the ability to use templates for the name of the entry points of ITs, which only seems to be used to put the name of the infile into the name of the entrypoint ("Display name" above). This again I believe is only really used for the "Active Interactive Tools" table (the title of the new window/tab is something else). So one alternative fix is to just remove this templating from all the ITs that use it, and not allow templating of entry point names. A more complicated fix is to refactor somehow to support both dependencies

[sveinugu]

Just to be clear: merging this PR would break path-based interactive tools!

[mvdbeek]

OK, I've moved the entry point creation so that the param_dict is available, but before templating out environment variables and config files.

[sveinugu]

LGTM. Thanks!

[mvdbeek]

Test failures are unrelated