Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.2] Backport model store fixes #17439

Merged
merged 5 commits into from
Feb 8, 2024
Merged

[23.2] Backport model store fixes #17439

merged 5 commits into from
Feb 8, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 8, 2024

Backport of #17346

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek requested a review from jmchilton February 8, 2024 10:02
@github-actions github-actions bot added area/testing area/database Galaxy's database or data access layer labels Feb 8, 2024
@github-actions github-actions bot added this to the 23.2 milestone Feb 8, 2024
jmchilton
jmchilton approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These unit test failures are concerning but seemingly unrelated right?

@nsoranzo
Copy link
Member

nsoranzo commented Feb 8, 2024

These unit test failures are concerning but seemingly unrelated right?

Yes, they are happening in all release branches.

@mvdbeek mvdbeek merged commit e70ff43 into galaxyproject:release_23.2 Feb 8, 2024
44 of 47 checks passed
@mvdbeek mvdbeek added the merge label Feb 8, 2024
@galaxyproject galaxyproject deleted a comment from github-actions bot Feb 8, 2024
@nsoranzo nsoranzo deleted the backport_model_store_fixes branch February 8, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/testing merge
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdbeek @nsoranzo @jmchilton