-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using tool data bundles as inputs to reference data select parameters #17435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
area/API
area/workflows
area/database
Galaxy's database or data access layer
area/datatypes
area/tool-framework
area/testing/integration
labels
Feb 7, 2024
jdavcs
reviewed
Feb 7, 2024
jdavcs
reviewed
Feb 7, 2024
mvdbeek
force-pushed
the
bundle_as_input
branch
6 times, most recently
from
February 8, 2024 19:51
89e3e8e
to
28d3da4
Compare
So ... this works for what we need in a first step. I guess these are the question marks I still have in my head:
|
mvdbeek
force-pushed
the
bundle_as_input
branch
from
February 9, 2024 14:25
f2dfe2f
to
de6d264
Compare
jmchilton
approved these changes
Feb 15, 2024
Amazing - thanks so much! I guess it needs a rebase. |
Since dicts here may be `TreeDict` instances.
Co-authored-by: John Davis <[email protected]>
It's None in the SelectToolParameterFieldWrapper context.
Without this user is mocked, whuch breaks `user.get_user_data_tables`
mvdbeek
force-pushed
the
bundle_as_input
branch
from
February 16, 2024 14:53
de6d264
to
a5134ed
Compare
jdavcs
approved these changes
Feb 16, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/API
area/database
Galaxy's database or data access layer
area/datatypes
area/testing/integration
area/testing
area/tool-framework
area/workflows
kind/feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables galaxyproject/idc#36, and we could later allow users to generate (or just upload) bundles.
How to test the changes?
(Select all options that apply)
License