Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes outdated Grid controller and backbone modules #17434

Merged
merged 16 commits into from
Feb 11, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Feb 7, 2024

Requires: #17415. Removes legacy grid controller and backbone modules. Legacy modules are still in use for the toolshed and reports interface but not for Galaxy itself anymore.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added kind/refactoring cleanup or refactoring of existing code, no functional changes area/client area/backend labels Feb 7, 2024
@guerler guerler added this to the 24.0 milestone Feb 7, 2024
@guerler guerler marked this pull request as ready for review February 7, 2024 18:44
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks a lot, Aysam!

@bgruening bgruening merged commit 8476819 into galaxyproject:dev Feb 11, 2024
54 checks passed
@guerler guerler deleted the grid_removal branch February 12, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/client kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants