Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix History contents genome_build filter postgresql bug #17384

Conversation

ahmedhamidawan
Copy link
Member

Check the user's db connection and use appropriate query/function.
Fixes #17371
This was caused in #15505 ; json_extract only works for sqlite databases.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Check the user's db connection and use appropriate query/function.
@ahmedhamidawan ahmedhamidawan added kind/bug area/database Galaxy's database or data access layer area/backend labels Jan 29, 2024
@ahmedhamidawan ahmedhamidawan added this to the 23.0 milestone Jan 29, 2024
@mvdbeek mvdbeek requested a review from jdavcs January 30, 2024 15:12
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mvdbeek mvdbeek merged commit 4c1c8e2 into galaxyproject:release_23.0 Feb 8, 2024
25 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants