Add element_identifier and ext to inputs config file export #17357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
topic/id_ext_inputs_configfile
branch
from
3bf1e99 to
1dd7898
Compare
|
This seems great! |
element identifiers are crucial for collections and need to be exposed in the inputs configfile export. it's too hacky to parse the identifier from the staging path (plus: the staging path is sanitised). I suggest to make the element_identifier a list, because it is for collections (there the first list elements are collection identifiers and the last the element identifier of the dataset), such that users (tool developers) do not need to check if it is a list or a string.
bernt-matthias
force-pushed
the
topic/id_ext_inputs_configfile
branch
from
71d8919 to
c37a4aa
Compare
jdavcs
reviewed
Feb 26, 2024
jdavcs
approved these changes
Feb 26, 2024
Co-authored-by: John Davis <[email protected]>
|
Thank you, @bernt-matthias! |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element identifiers are crucial for collections and need to be exposed in the inputs configfile export. it's too hacky to parse the identifier from the staging path (plus: the staging path is sanitised).
I suggest to make the element_identifier a list, because it is for collections (there the first list elements are collection identifiers and the last the element identifier of the dataset), such that users (tool developers) do not need to check if it is a list or a string.
TODO:
How to test the changes?
(Select all options that apply)
License