Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of graphene-sqlalchemy, bump to 3.0.0rc1 #17216

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Dec 19, 2023

Fixes breaking changes referenced here: #17185 (comment) (also see graphql-python/graphene-sqlalchemy#371)

Reason: dependency conflict preventing upgrade to SQLAlchemy 2.0 (#12541): current beta releases of graphene-sqlalchemy (3.0.0b3, 3.0.0b4) require sqlalchemy < 2. The 3.0.0rc1 release is 2.0-compatible.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes dependencies Pull requests that update a dependency file labels Dec 19, 2023
@jdavcs jdavcs added this to the 24.0 milestone Dec 19, 2023
@jdavcs jdavcs requested a review from jmchilton December 19, 2023 17:47
@jdavcs jdavcs mentioned this pull request Dec 19, 2023
4 tasks
@jmchilton jmchilton merged commit 39ad53c into galaxyproject:dev Dec 22, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies area/packaging dependencies Pull requests that update a dependency file kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants