Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsd: reorder choices for permissive boolean #17187

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

bernt-matthias
Copy link
Contributor

in order of preference. language server seems to take the suggested values from this list using this ordering.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

in order of preference. language server seems to take the
suggested values from this list using this ordering.
@github-actions github-actions bot added this to the 23.2 milestone Dec 14, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Dec 14, 2023

I guess that's moot now that it's a union (starting from 23.2), where the actual boolean comes first ? No problem either way

@bernt-matthias
Copy link
Contributor Author

I guess that's moot now ...

So you mean that starting from 23.2 the order has no meaning anymore and the preference might need to be implemented directly in the language server?

@mvdbeek
Copy link
Member

mvdbeek commented Dec 14, 2023

It's a union, I don't know what the language server does, but if it follows the schema and uses the first valid option it'll be fine.

@davelopez
Copy link
Contributor

The language server uses a custom parser for the XSD (it was a toy project to learn Python 🤷‍♂️), but I don't remember from the top of my head, I guess if the first valid option is the one we want to present to the user it will work. For enums like this, it will present the options as they appear in the declaration not sure for unions though.

@mvdbeek mvdbeek merged commit d0c78d5 into galaxyproject:dev Dec 15, 2023
45 of 47 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants