Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop fastapi-utils.InferringRouter in favor of fastapi.APIRouter #17184

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Dec 13, 2023

As per fastapi-utils: "InferringRouter is deprecated, as its functionality is now provided in fastapi.APIRouter", DeprecationWarning (ref https://github.com/dmontagu/fastapi-utils/blob/master/fastapi_utils/inferring_router.py).

I think fastapi.APIRouter is all we need.

Note: this is also part of solving the issue of fastapi-utils requiring SQLAlchemy < 2, which prevents us from upgrading to SA 2.0.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

As per fastapi-utils warning: "InferringRouter is deprecated, as its functionality is now provided in fastapi.APIRouter", DeprecationWarning
@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Dec 13, 2023
@github-actions github-actions bot added this to the 23.2 milestone Dec 13, 2023
@jdavcs jdavcs merged commit 59c2ed7 into galaxyproject:dev Dec 13, 2023
48 of 49 checks passed
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants