Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Trackster, Circster, Sweepster and Phyloviz Makos #17158

Closed
wants to merge 10 commits into from

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 10, 2023

This PR removes the legacy mako, js-code of Trackster, Circster, Sweepster and Phyloviz built-in visualizations. This is a critical prerequisite for moving forward with the overall client modernization in regard to backbone-based code and legacy makos.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Dec 10, 2023
@guerler guerler added this to the 23.2 milestone Dec 10, 2023
@guerler guerler marked this pull request as ready for review December 10, 2023 18:27
@guerler guerler marked this pull request as draft December 11, 2023 07:52
@bgruening
Copy link
Member

I think Trackster, Circster, Sweepster have been discussed many times in various GCCs to be removed. Thanks @guerler for taking the lead here. 👍
I'm not sure about Phyloviz. Do we know if this is used? Do we have a replacement?

@nekrut I remember you have at least participated in those discussions and have been in favor of removing Trackster in favor of other Genome Browsers.

@mvdbeek
Copy link
Member

mvdbeek commented Dec 11, 2023

I also like this a lot, but maybe the order should be addition of embedded IGV (or jbrowse) first before we remove trackster ?

@nekrut
Copy link
Contributor

nekrut commented Dec 11, 2023

100% REMOVE!

@guerler
Copy link
Contributor Author

guerler commented Feb 11, 2024

Closed in favor of #17415

@guerler guerler closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants