Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Add HEAD route to job_files endpoint #17072

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 23, 2023

This is to make sure resuming downloads works out of the box (it should already work if nginx_x_accel_redirect_base or apache_xsendfile is set up).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool - what a clean fix.

@martenson martenson merged commit 4a7dbe9 into galaxyproject:release_23.1 Nov 27, 2023
40 checks passed
@martenson martenson deleted the add_head_route_to_job_files branch November 27, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants