[23.1] Fix copying metadata to copied job outputs #17007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
changed the title
github-actions
bot
added
area/testing
area/database
mvdbeek
force-pushed
the
fix_copied_outputs_metadata
branch
from
7cc50db to
824d346
Compare
mvdbeek
commented
Nov 10, 2023
| @@ -667,7 +667,6 @@ def from_external_value(self, value, parent, path_rewriter=None): | |||
| # directory. Correct. | |||
| file_name = path_rewriter(file_name) | |||
| mf.update_from_file(file_name) | |||
| os.unlink(file_name) | |||
There was a problem hiding this comment.
This isn't the right place to do this, cleaning up the job working directory will handle this correctly. fixes the directory metadata strategy case
There was a problem hiding this comment.
I bet this is also what happened in #14087
5 tasks
That one might be related. |
mvdbeek
force-pushed
the
fix_copied_outputs_metadata
branch
from
824d346 to
eb3802e
Compare
yep, fixed in a rebase |
mvdbeek
force-pushed
the
fix_copied_outputs_metadata
branch
from
eb3802e to
2fc1b64
Compare
bgruening
approved these changes
Nov 10, 2023
|
Merci! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17003
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License