Refactor workflow step display stuff toward TS & reuse. #17004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
area/UI-UX
kind/refactoring
Comment on lines
68
to
71
| watch(props, () => { | ||
| initStores(); | ||
| }); | ||
| initStores(); |
There was a problem hiding this comment.
Suggested change
| watch(props, () => { | |
| initStores(); | |
| }); | |
| initStores(); | |
| watch( | |
| props, | |
| () => { | |
| initStores(); | |
| }, | |
| { immediate: true } | |
| ); |
There was a problem hiding this comment.
Amazing - thank you for this trick!
client/src/components/WorkflowInvocationState/WorkflowStepIcon.vue
Outdated
Show resolved
Hide resolved
| @@ -2,9 +2,11 @@ | |||
| <div class="d-flex" :data-step="workflowStep.id"> | |||
| <div class="ui-portlet-section" style="width: 100%"> | |||
| <div class="portlet-header portlet-title portlet-operations cursor-pointer" @click="toggleStep"> | |||
| <i :class="'portlet-title-icon fa mr-1 ' + stepIcon"></i> | |||
| <WorkflowStepIcon :class="portlet - title - icon" :step-type="workflowStepType" /> | |||
There was a problem hiding this comment.
Suggested change
| <WorkflowStepIcon :class="portlet - title - icon" :step-type="workflowStepType" /> | |
| <WorkflowStepIcon class="portlet-title-icon" :step-type="workflowStepType" /> |
jmchilton
force-pushed
the
merge_preview_invocation
branch
2 times, most recently
from
32febd3 to
57622ae
Compare
jmchilton
force-pushed
the
merge_preview_invocation
branch
from
57622ae to
665928e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkflowInvocationStep.vueto Typescript.How to test the changes?
(Select all options that apply)
License