Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-optional integer/float params without value attribute #16966

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Nov 2, 2023

Previously a tool with such an input would fail to load.

Also:

  • Add test tool.
  • Add some type annotations to ToolParameter methods
  • Use super()

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have read the code correctly, then bool should already work. For selects we have #9203 (comment)

However for the numeric parameters your fix looks good to me.

@bernt-matthias
Copy link
Contributor

Fixes #16960

@nsoranzo
Copy link
Member Author

nsoranzo commented Nov 2, 2023

The failing Selenium test is unrelated (looks like that lib/galaxy_test/selenium/test_workflow_editor.py::TestWorkflowEditor::test_edit_license is flaky).

@dannon dannon merged commit 0db0444 into galaxyproject:dev Nov 3, 2023
49 of 50 checks passed
@nsoranzo nsoranzo deleted the issue_16960 branch November 3, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants