Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize to W3C naming for color. #16949

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Standardize to W3C naming for color. #16949

merged 2 commits into from
Oct 31, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Oct 31, 2023

I thought about this right after merging #16612. We have previously always used color instead of colour in the application, and I think we should stick with it. The sans-u spellings are the expected spellings in html/css and computing in general, and I can see this being problematic down the road when these things are serialized out, potentially hand-edited, etc. We need to be consistent here, at least in the codebase and potentially serialized artifacts. I'm not particularly worried about language choice in news briefs, blog posts, etc., just in the technical bits.

This will probably flag an error in tests as it was a pretty quick find and replace, but I wanted to open it ASAP for testing so we can do this without needing a second migration to rename the column.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added the area/database Galaxy's database or data access layer label Oct 31, 2023
@github-actions github-actions bot added this to the 23.2 milestone Oct 31, 2023
@dannon dannon added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Oct 31, 2023
@jdavcs
Copy link
Member

jdavcs commented Oct 31, 2023

Can you, please, move the migration into a separate commit?

@dannon
Copy link
Member Author

dannon commented Oct 31, 2023

@jdavcs It's not a new migration -- it's tweaking one that was just added in the parent commits merged hours ago. I can make a separate migration if we need to, but it felt like overkill for something nobody should have applied yet.

@jdavcs
Copy link
Member

jdavcs commented Oct 31, 2023

Oh yeah, I see now. It will break things for anyone using dev though (all devs - staff and anyone else contributing). I think it's OK to make a migration: it's a perfectly legit reason for a migration; besides, it could have happened across releases, in which case we'd have to anyway.

@mvdbeek mvdbeek merged commit a5b88e0 into galaxyproject:dev Oct 31, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants