Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Skip change_datatype things if we're not actually changing the extension #16931

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[23.1] Skip change_datatype things if we're not actually changing the extension #16931

merged 2 commits into from
Oct 26, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 26, 2023 •
edited
Loading

Side-steps a problem with FileParameter in the most efficient way possible. This likely became a problem for one of Wolfgang's workflow after we dropped some earlier unnecessary flushes.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Skip change_datatype things if we're not actually changing the extension
ca5132d 
Side-steps a problem with FileParameter in the most efficient way
possible. This likely became a problem for one of Wolfgang's workflow
afer we dropped some earlier unnecessary flushes.
@github-actions github-actions bot added this to the 23.2 milestone Oct 26, 2023
@martenson martenson merged commit 3e1d866 into galaxyproject:release_23.1 Oct 26, 2023
34 of 37 checks passed
@jdavcs
Copy link
Member

jdavcs commented Oct 26, 2023

@martenson @mvdbeek there was an unresolved comment.

@jdavcs jdavcs mentioned this pull request Oct 26, 2023
Merged
1 task
@nsoranzo nsoranzo deleted the skip_datatype_change branch October 26, 2023 21:52
mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Oct 27, 2023
@mvdbeek
Add regression test for galaxyproject#16931
21fb9be
@mvdbeek mvdbeek mentioned this pull request Oct 27, 2023
Merged
4 tasks
@wm75 wm75 mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavcs jdavcs jdavcs approved these changes

@martenson martenson martenson approved these changes

Assignees
No one assigned
Labels
area/workflows kind/bug
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdbeek @jdavcs @martenson