Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix discarded dataset ordering in Storage Dashboard #16929

Conversation

davelopez
Copy link
Contributor

Fixes #16898

When you delete an output of a tool the HDA size is null, by default, Postgresql seems to sort null values first. This change uses the correct null sorting for the size attribute in each case.

Before

Screenshot from 2023-10-26 10-50-33

After

Screenshot from 2023-10-26 10-56-09

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 26, 2023
@martenson martenson merged commit 12b20c6 into galaxyproject:release_23.1 Oct 27, 2023
38 of 39 checks passed
@martenson
Copy link
Member

thanks @davelopez !

@davelopez davelopez deleted the 23.1_fix_discarded_dataset_ordering branch October 27, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants