Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GQL infinite scrolling in tool shed. #16914

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jmchilton
Copy link
Member

Pulled things one level down from apollo and got them working properly. I couldn't figure out how to get the apollo cache working correctly anymore and the actual code here that is left is pretty simple and should be easier to tweak.

Fixes #16813

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Deploy to test toolshed and see if it is working? Works on my laptop for a small test case.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review October 25, 2023 15:23
@github-actions github-actions bot added this to the 23.2 milestone Oct 25, 2023
@mvdbeek mvdbeek merged commit 4fcf3b5 into galaxyproject:dev Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the infinite scroll within category on TS2.0 does not work
2 participants