Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove record access handling for Invenio RDM plugin #16900

Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Oct 23, 2023

I was checking the compatibility of the Invenio RDM plugin, with the new version of Zenodo, and it seems it doesn't allow access handling through the API using your personal token. So when creating a new record and trying to set the access options it will return a You don't have permissions to manage record access error.

In any case, it's safer (and simpler) to always work with draft versions of records from Galaxy and leave the publication handling directly to the remote platform (Zenodo/Invenio frontend).

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • You can try this out with the Zenodo Sandbox which already uses the new Invenio-based API:

      # file_sources_conf.yml
      - type: inveniordm
        id: zenodo
        doc: Zenodo RDM Sandbox for testing
        label: Zenodo RDM Sandbox
        url: https://zenodo-rdm-qa.web.cern.ch
        token: ${user.preferences['zenodo|token']}
        public_name: ${user.preferences['zenodo|public_name']}
        writable: true
      
      # user_preferences_extra_conf.yml
          zenodo:
              description: Your Zenodo RDM Account
              inputs:
                  - name: token
                    label: Personal Token to publish records to Zenodo RDM
                    type: secret
                    store: vault # Requires setting up vault_config_file in your galaxy.yml
                    required: False
                  - name: public_name
                    label: Public name to publish records (formatted as "Lastname, Firstname")
                    type: text
                    required: False

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 23, 2023
@davelopez davelopez force-pushed the remove_invenio_record_access_handling branch from 691bd57 to c774199 Compare October 25, 2023 08:17
It is better to always work with `draft` versions of records and leave the publication handling directly to the Invenio platform.

In addition, some Invenio RDM compatible repositories like Zenodo don't allow access handling through the API using your personal token.
@davelopez davelopez force-pushed the remove_invenio_record_access_handling branch from c774199 to c4d225c Compare October 25, 2023 10:41
@dannon dannon merged commit a8b32e9 into galaxyproject:dev Oct 30, 2023
@davelopez davelopez deleted the remove_invenio_record_access_handling branch October 30, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants