Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Latest Updates" order in tool shed 2.0 #16894

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

jmchilton
Copy link
Member

Fixes #16812 probably.

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Deploy to test and see if the respective lists are different now.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the title Possible fix for https://github.com/galaxyproject/galaxy/issues/16812 Fix "Latest Updates" order in tool shed 2.0 Oct 23, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Oct 23, 2023

Since that's client-side only, is there a way to check against the test toolshed, similar to what we're doing with CHANGE_ORIGIN=true GALAXY_URL="https://usegalaxy.eu/" yarn run develop ?

@jmchilton
Copy link
Member Author

I'm not having any luck getting this working. I'd love help though if people have ideas - I've tried to use vite's server proxy stuff and I get stuff like this:

{
    "err_msg": "Wrong guid ''eb142648ac45b77092f9904b054a3582ab8ebce106f8a2763d8a48a7b95723c4c971061715c49c74'' specified, unable to decode.",
    "err_code": 400009
}

Which I think is coming from the testtoolshed. A cookie issue I suppose.

@martenson
Copy link
Member

Is this the one you'd like reviewed @jmchilton?

@martenson martenson self-assigned this Aug 6, 2024
@jmchilton jmchilton marked this pull request as ready for review August 6, 2024 14:10
@github-actions github-actions bot added this to the 24.2 milestone Aug 6, 2024
@mvdbeek mvdbeek merged commit 19fa41c into galaxyproject:dev Aug 16, 2024
50 of 51 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Aug 16, 2024

Thanks, that makes sense!

@martenson martenson deleted the ts_bug branch August 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the list of newest repositories on TS2.0 is incorrect
3 participants