[23.1] Fix History item deletion/undeletion reactivity with filter and ToolForm input field

[ahmedhamidawan]

Reactivity with History filter

If you apply the filter: deleted:any, your deleted items come into view along with other active items. But when you undelete an item, there is a bug where it is hidden even though the current filter is deleted:any

Before (Bug)	After (Fixed)
history_items_store_delete_before.mp4	history_items_store_delete_after.mp4
Undeleted item goes away even though filter includes "deleted:any"	Undeleted item comes back into the panel as an active item

Reactivity with FormDisplay form input

If there is a change in the current history that doesn't affect currently selected item in the Tool form, we do not reflect the change in the select field. Fix: Do Vue.set(input, "attributes", newValue); instead of just input.attributes = newValue;

Before (Bug)
If you delete/undelete an item in the history that is not already selected in the select field, the field does not react to changes.
tool_form_select_dataset_reactive_before.mp4

After (Fixed)
The field now reacts to a change in the current history
tool_form_select_dataset_reactive_after.mp4

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Thanks for backporting the minimal fix and following up with the refactoring in #16873!

The selenium test failure seems related though 🤔