Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in SA statement: desc() applied to column, not statement #16887

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Oct 19, 2023

desc() is applied to the column object, not the statement.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/toolshed area/database Galaxy's database or data access layer labels Oct 19, 2023
@jdavcs jdavcs added this to the 23.2 milestone Oct 19, 2023
@martenson martenson merged commit 5134f2f into galaxyproject:dev Oct 19, 2023
40 of 41 checks passed
@martenson
Copy link
Member

Thanks John!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer area/toolshed kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants