Visually indicate currently viewed/edited dataset

[ahmedhamidawan]

Fixes #16784

Indicates which dataset is currently being viewed/edited in ContentItem using a left-border:

content_item_current_indicator_4.mp4

content_item_current_indicator_3.mp4

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

This is very cool, but I wonder if there is something more standard than the white color ? Could it be an outline change or some color variant or something along those lines ?

[dannon]

I should have updated here; @ahmedhamidawan and I discussed this out of band and the plan is to shift back to the sticker whole-card-highlight, instead of the white per-interface icon.

[ahmedhamidawan]

Failing tests:

FAILED lib/galaxy_test/selenium/test_workflow_editor.py::TestWorkflowEditor::test_edit_license - AssertionError: Expected data-license to have value [MIT] but had value [null]

FAILED lib/galaxy_test/selenium/test_histories_published.py::TestPublishedHistories::test_published_histories_sort_by_name - AssertionError: assert '9viqk239u1' == '143d99z7rw'

seem unrelated to the ContentItem changes made here

[martenson]

Overall I like the style and I think it will help people navigate histories.

Couple of cases that might use some polish:

• here I clicked (eye) icon on #12 and then expanded #10 -- it is a bit confusing since two things are "highlighted" at the same time
  
• the ribbon shows for eye, edit, bugreport, info buttons but does not show for rerun, visualize, help buttons -- this feels arbitrary, why some but not the others?

[ahmedhamidawan]

Thank you @martenson !

here I clicked (eye) icon on #12 and then expanded #10 -- it is a bit confusing since two things are "highlighted" at the same time

The ribbon indicates the dataset currently being "worked on" (or viewed) in the center panel, so i feel it makes sense to keep that highlighted, no? I wouldn't think you would want it to go away if you click another item, because expanding the other item still might not mean the first one isn't being operated on in the center

the ribbon shows for eye, edit, bugreport, info buttons but does not show for rerun, visualize, help buttons -- this feels arbitrary, why some but not the others?

The ribbon only shows for those views since they are directly related to the dataset (also because the id is in the URL), whereas, rerun is emitted for the current dataset but one can change the chosen dataset value in the Tool form, at which point the ribbon wouldn't make sense

[martenson]

Please see responses below. Overall I suggest let's roll with this and see if we get more feedback.

because expanding the other item still might not mean the first one isn't being operated on in the center

My read would be that you are more likely to have shifted context to the newly selected than not.

The ribbon only shows for those views since they are directly related to the dataset (also because the id is in the URL), whereas, rerun is emitted for the current dataset but one can change the chosen dataset value in the Tool form, at which point the ribbon wouldn't make sense

Visualization is directly related to the dataset. I give you that the other two I mentioned are less related though.