Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #16851

Merged
merged 1 commit into from
Oct 13, 2023
Merged

chore: fix typos #16851

merged 1 commit into from
Oct 13, 2023

Conversation

afuetterer
Copy link
Contributor

Hi, this is my first PR to the project. Please feel free to close or adapt. This PR fixes some minor typos.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 13, 2023
@bgruening
Copy link
Member

Welcome @afuetterer! That is a pretty good start to dive into the code base :)
Thanks!

@afuetterer
Copy link
Contributor Author

Thank you.

nsoranzo
nsoranzo reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I've suggested changes to make black happy.

test/unit/files/test_ftp.py Outdated Show resolved Hide resolved
lib/galaxy/webapps/galaxy/controllers/dataset.py Outdated Show resolved Hide resolved
lib/galaxy/webapps/galaxy/controllers/dataset.py Outdated Show resolved Hide resolved
lib/tool_shed/test/functional/test_0170_complex_prior_installation_required.py Outdated Show resolved Hide resolved
lib/tool_shed/test/functional/test_1190_complex_prior_installation_required.py Outdated Show resolved Hide resolved
@jdavcs
Copy link
Member

jdavcs commented Oct 13, 2023

Very nice, thank you! I didn't realize we had so many the the cases :)

@afuetterer
Copy link
Contributor Author

Happens very easily I guess. :)

@afuetterer @nsoranzo
chore: fix typos
347e7b8 
Co-authored-by: Nicola Soranzo <[email protected]>
@dannon
Copy link
Member

dannon commented Oct 13, 2023

What a weird typo to happen so frequently, thanks for the fixes!

@nsoranzo nsoranzo merged commit 80cc5dd into galaxyproject:dev Oct 13, 2023
41 of 44 checks passed
@nsoranzo
Copy link
Member

Thanks for the the fixes 😆

@galaxyproject galaxyproject deleted a comment from github-actions bot Oct 14, 2023
@afuetterer afuetterer deleted the fix-typos branch October 14, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
5 participants
@afuetterer @bgruening @jdavcs @dannon @nsoranzo