Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Specify uid for the k8s image #16844

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

afgane
Copy link
Contributor

@afgane afgane commented Oct 12, 2023

23.1 images build with galaxy user id as 100 while previous images built with uid 101, which is causing permission issues when starting Galaxy that relies on folder structures from previous setup so set the uid explicitly.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 12, 2023
@@ -166,7 +166,7 @@ RUN set -xe; \

# Create Galaxy user, group, directory; chown
RUN set -xe; \
adduser --system --group $GALAXY_USER \
adduser --system --group --uid 101 $GALAXY_USER \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set something like $GALAXY_UID at the top of the file where $GALAXY_USER is set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great, I think this could be a follow up PR if it is important to either of you!

@jmchilton jmchilton merged commit 8082c2d into galaxyproject:release_23.1 Oct 13, 2023
@nsoranzo nsoranzo changed the title Specify uid for the k8s image [23.1] Specify uid for the k8s image Oct 13, 2023
@galaxyproject galaxyproject deleted a comment from github-actions bot Oct 14, 2023
ksuderman added a commit to anvilproject/galaxy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants