Fix collection drilling

[davelopez]

Fixes #16785

This should fix the selenium test failure:

FAILED lib/galaxy_test/selenium/test_history_multi_view.py::TestHistoryMultiView::test_list_list_display - selenium.common.exceptions.TimeoutException: Message: Failed waiting on history item 3 to become visible, visible datasets include [#dataset-f06d708dacad69d8,#dataset-da92407cb46a61f3]. Timeout waiting on CSS selector [.multi-history-panel .content-item[data-hid="3"]] to become visible.

The important stuff is in the function onViewSubCollection inside CollectionPanel.vue. I'm not 100% sure this is how we are supposed to query the elements of a sub-collection i.e. by calling /api/dataset_collections/{hdca_id}/contents/{collection_id} where hdca_id is the top HDCA in the history and collection_id is the DatasetCollection ID in DCObject, but it works on my tests... it is still a little fuzzy in my head how sub-collections work 😅

It also fixes the store by using a composed key [hdca_id + collection_id] to store and retrieve elements from a collection, since just using the collection ID can create collisions between HDCAs (top level) and sub-collections (DCOs).

How to test the changes?

• This is a refactoring of components with existing test coverage.

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

I am not sure if this is the right way to handle collections ... that it isn't obvious to me doesn't mean it's not the right way to do this, but maybe a quick summary helps you make the right choice ?

Generally speaking we have 3 concepts:

• HistoryDatasetCollectionAssociation:
  • Top level history item that has a one-to-one reference to a History and a DatasetCollection
• DatasetCollection:
  • Contains a one-to-many reference to DatasetCollectionElement items
• DatasetCollectionElement:
  • Links a parent collection (via dataset_collection_id) to its elements. The elements can be:
    • HistoryDatasetAssociation ("hda", via hda_id)
    • LibraryDatasetDatasetAssociation ("ldda", via ldda_id (we're not using this thankfully ... 😅 ))
    • DatasetCollection ("child_collection", via child_collection_id ... this is how nested collections work)

Ideally it'd always be clear what the item is that you're dealing with. I hope that helps clarify how you want to handle this.

[davelopez]

Thank you so much for the summary! I really appreciate it. I will try to think a bit more about how to handle this with this information 👍

[davelopez]

Thanks again @mvdbeek!
I have a clearer idea of how collections work internally now. I've refactored and added a bit of docs here and there. Hopefully, it all makes more sense now. If not, please let me know and I'll give it another shot.

[mvdbeek]

Thanks for fixing this! I'd love if this was closer to the API and we didn't have to invent additional models like SubCollection, but maybe that would require having a better way to access elements of a collection.