Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix short ids in tool panel views. #16800

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jmchilton
Copy link
Member

Fix using short ids in tool panel views. Use new data structure to optimize get_tool(exact=False) as well - should speed up certain kinds of toolbox related operations.

A redo of #16664 for main though. The tool shed repo uninstall tests caught a pretty serious bug here that I believe I have fixed now also.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Oct 6, 2023

did you mean for the first commit to be in here?

Use new data structure to optimize get_tool(exact=False) as well - should speed up certain kinds of toolbox related operations.
@jmchilton jmchilton marked this pull request as ready for review October 6, 2023 19:05
@mvdbeek mvdbeek merged commit 11110c2 into galaxyproject:release_23.1 Oct 6, 2023
@github-actions github-actions bot added this to the 23.2 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants