Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file_name property with get_file_name function #16783

Merged

Conversation

SergeyYakubov
Copy link
Contributor

Following discussions in #16702, this PR replaces .file_name property with get_file_name function so that later on we could pass parameters to this function (control pulling from an object store, pass user object for authentication, ... ). No functionality changes in this PR.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SergeyYakubov - this is a ton of work! Sorry for the long wait; at first I wasn't entirely sure whether these changes may or may not cause problems for serialized dataset objects - but now I see that's not the case. Looks good!

@jdavcs jdavcs force-pushed the get-rid-of-filename-property branch from 46821a0 to c30a4c0 Compare November 8, 2023 22:18
@jdavcs jdavcs merged commit f91693d into galaxyproject:dev Nov 8, 2023
44 checks passed
Copy link

github-actions bot commented Nov 8, 2023

This PR was merged without a "kind/" label, please correct.

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes and removed area/documentation area/testing area/API area/jobs area/workflows area/tools area/admin area/database Galaxy's database or data access layer area/datatypes area/scripts labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants