Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ELIXIR AAI button with Life Science login #16762

Merged

Conversation

sebastian-schaaf
Copy link
Contributor

@sebastian-schaaf sebastian-schaaf commented Sep 29, 2023

Galaxy has been reviewed recently in the course of ELIXIR's Recommended Interoperability Resources evaluation (we applied).
A minor criticism was that still the old ELIXIR AAI login button is in use; ELIXIR migrated to Life Science (LS) Login with April 2022. Life Science RI recommends using the button introduced in this PR.
Appearantly, underlying technical changes will follow for the particular resources upon being contacted by Life Science RI. Until then, the ELIXIR implementation remains:

Q: What is the plan for migrating my service to the LS Login?

A: Services will be updated one by one, we will contact you separately, timing depends on the functionality your service is using and its support in LS Login. Please wait for us to contact you with detailed instructions.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

updating the old (orange) ELIXIR AAI login button with the new (grey) Life Science Login button (location 1/2)
updating the old (orange) ELIXIR AAI login button with the new (grey) Life Science Login button (location 2/2)
updating the old (orange) ELIXIR AAI login button with the new (grey) Life Science Login button (location 1/2; new link)
@github-actions github-actions bot added the area/auth Authentication and authorization label Sep 29, 2023
@github-actions github-actions bot added this to the 23.2 milestone Sep 29, 2023
@nsoranzo nsoranzo changed the title Replace elixir aai login button Replace ELIXIR AAI button with Life Science login Sep 29, 2023
@nsoranzo nsoranzo merged commit 15414b2 into galaxyproject:dev Sep 29, 2023
43 of 47 checks passed
@bgruening
Copy link
Member

Thanks @sebastian-schaaf. Do you want to backport this to EU?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Authentication and authorization kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants