Fix bug in User.all_roles query + use SA2.0 #16761
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this query never worked as intended: it always raised an error (clauses like
joinedload(User.roles.role)
don't work). The error was caught and silenced, so it was never detected.The proposed solution produces a simple and straightforward query:
We union the user roles with the group roles for groups to which the user belongs - no need to apply multiple joinedload options to the User.
Ref: #12541
How to test the changes?
(Select all options that apply)
License