Convert ISO to UTC for Date/Time in workflow reports #16758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Sep 28, 2023
Comment on lines
22
to
23
| const iso = new Date(invocation && invocation["create_time"]); | ||
| return iso.toUTCString(); |
There was a problem hiding this comment.
This looks good, but does that need to be fixed in the PDF as well ?
2 tasks
|
Can you please run |
assuntad23
changed the title
mvdbeek
reviewed
Oct 9, 2023
Co-authored-by: Marius van den Beek <[email protected]>
mvdbeek
reviewed
Oct 10, 2023
| @@ -280,7 +280,8 @@ def test_generate_invocation_time(self): | |||
| invocation = self._new_invocation() | |||
| self.app.workflow_manager.get_invocation.side_effect = [invocation] # type: ignore[attr-defined,union-attr] | |||
| result = self._to_basic(example) | |||
| assert f"\n {invocation.create_time.isoformat()}" in result | |||
| expectedtime = invocation.create_time.strftime("%m/%d/%Y, %H:%M:%S") | |||
There was a problem hiding this comment.
Can we use the iso date format ( [YYYY]-[MM]-[DD]) ?
assuntad23
commented
Oct 17, 2023
changing format of string time to more closely match iso format
changing format of string time to more closely match iso format
mvdbeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16556
Instead of printing out ISO date time, dislpaying time format in UTC.
How to test the changes?
(Select all options that apply)
License