Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy server-side search #16755

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Sep 28, 2023

We don't use this. Checked this before upgrading for SA2.0.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/backend labels Sep 28, 2023
@jdavcs jdavcs added this to the 23.2 milestone Sep 28, 2023
@jdavcs jdavcs requested a review from a team September 28, 2023 14:05
@dannon
Copy link
Member

dannon commented Sep 28, 2023

Technically we should probably do a deprecation cycle this since it's a part of the API? (do you want to quickly add that to the 23.1 release notes?)

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably a good idea to drop this, but this needs a deprecation announcement. That we don't use this in the client doesn't necessarily mean no-one uses.

@jmchilton
Copy link
Member

I'm fine removing it... I'm not aware of any users. For some perspective this was added by Kyle Ellrott in the first couple years I was working for the project. He was working on a project to ship whole workflows to other Galaxy for execution. Still a noble goal and would solve all sorts of issues around temporary data retention, data locality, etc.. But I think the approach would not be based on search and GQL... I think we would want to ship the whole workflow request and refine the workflow invocation export for trusted internal import - the way we do for jobs internally.

@jdavcs jdavcs merged commit 93fd7c9 into galaxyproject:dev Sep 28, 2023
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants