Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate collection attributes store to Pinia #16752

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Migrate collection attributes store to Pinia #16752

merged 6 commits into from
Oct 11, 2023

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Sep 27, 2023 •
edited
Loading

Includes some unit tests for the store.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Sep 27, 2023
@github-actions github-actions bot added this to the 23.2 milestone Sep 27, 2023
@davelopez davelopez marked this pull request as draft October 11, 2023 12:55
@davelopez davelopez force-pushed the migrate_collection_attributes_store_pinia branch from e69f36d to c4529f7 Compare October 11, 2023 13:00
@davelopez davelopez marked this pull request as ready for review October 11, 2023 13:01
@dannon
Copy link
Member

dannon commented Oct 11, 2023

Thanks!

@dannon dannon merged commit cd287a0 into galaxyproject:dev Oct 11, 2023
20 checks passed
@davelopez davelopez deleted the migrate_collection_attributes_store_pinia branch October 12, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElectronicBlueberry ElectronicBlueberry ElectronicBlueberry left review comments

@dannon dannon dannon approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
UI/UX Working Group - weeklies
Archived in project
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @dannon @ElectronicBlueberry