[23.1] Fix workflow output display without label #16749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
changed the title
And since that makes it considerably easier to have duplicate output labels we now highlight duplicate output labels.
using a unique label that we compute on the fly. Should hopefully not happen often now that we set a default label when we make an output a workflow output.
mvdbeek
force-pushed
the
fix_output_display_without_label
branch
from
b6f7ecf to
a7ab719
Compare
Co-authored-by: Laila Los <[email protected]>
|
Test failures are unrelated |
bgruening
approved these changes
Sep 28, 2023
nsoranzo
reviewed
Jan 30, 2024
Comment on lines
+8379
to
+8381
| label = ( | ||
| label | ||
| ) = f"{output_assoc.workflow_output.output_name} (Step {output_assoc.workflow_output.workflow_step.order_index + 1})" |
There was a problem hiding this comment.
@mvdbeek I suppose this can just be:
label = f"{output_assoc.workflow_output.output_name} (Step {output_assoc.workflow_output.workflow_step.order_index + 1})"?
There was a problem hiding this comment.
yes, I don't know what happened here 🤷
There was a problem hiding this comment.
OK, no worries, fixing it as part of applying the new black 2024 stable style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Delphine-L noticed that workflow outputs without a label were not shown in the invocation page. The first commit makes it so that when you add a workflow output it default to using the output_name as the label. It also warns you when that output label is not unique. The second commit provides a fallback label for invocation outputs.
How to test the changes?
(Select all options that apply)
License