Selective bold text #16748
Merged
Selective bold text #16748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bold-text already used in primary table [high priority]
…s) because bold-text already used in Label Details (e.g. filenames) [moderate priority]
…ls lacked secondary text requiring de-emphasis (i.e. no change made to Workflows List page) [low priority]
hujambo-dunia
requested review from
ElectronicBlueberry,
dannon and
martenson
|
I think it was fine to have table column headers in bold? |
Yes, I agreed with you :) I didn't make a code change to the table column headers. I just created the wrong screenshots. I can update the screenshots in 5 minutes or so. |
dannon
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to corrections made in #16515 issue where bold text became visible in Chrome and seeing that bold-text was used in too many places, this new PR corrects that by only selectively applies bold text to reflect actual "emphasis" when placed next to non-emphasized text. Commits in order of priority (ie. can be selectively cherry-picked as needed). Fix for #16631 issue.
How to test the changes?
(Select all options that apply)
License