Don't copy collection elements in test_dataset_collection_hide_originals
#16747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
added
kind/enhancement
kind/refactoring
mvdbeek
reviewed
Sep 26, 2023
mvdbeek
approved these changes
Sep 27, 2023
…inals`` Follow-up to galaxyproject#16717 . Minimal performance gain but helps document the parameter use after the change in default value to True.
Prevent unexpected behaviour of the API. Actually raise `RequestParameterInvalidException` exception if this conflicts with `copy_required` (i.e. dbkey not None).
nsoranzo
force-pushed
the
test_dataset_collection_hide_originals_copy_elements
branch
from
b0aabed to
d26186f
Compare
nsoranzo
deleted the
test_dataset_collection_hide_originals_copy_elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #16717 .
Minimal performance gain but helps document the parameter use after the change in default value to True.
Also:
How to test the changes?
(Select all options that apply)
License