[23.1] Fix allowlist deserialization in file sources #16729

mvdbeek · 2023-09-22T17:25:30Z

Should fix the remaining tests

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

lib/galaxy/config/parsers.py

mvdbeek added kind/bug area/testing/api area/testing/selenium labels Sep 22, 2023

github-actions bot added this to the 23.2 milestone Sep 22, 2023

Fix allowlist deserialization in file sources

cac5495

mvdbeek force-pushed the fix_allowlist_deserialization branch from 3d3745e to cac5495 Compare September 22, 2023 17:38

jmchilton reviewed Sep 22, 2023

View reviewed changes

lib/galaxy/config/parsers.py Outdated Show resolved Hide resolved

Add missing attribute in unit test config

3087717

mvdbeek force-pushed the fix_allowlist_deserialization branch from 225e7ec to 80ca468 Compare September 22, 2023 19:04

martenson approved these changes Sep 22, 2023

View reviewed changes

Move config parsing to util package

bb2daaf

mvdbeek force-pushed the fix_allowlist_deserialization branch from 80ca468 to bb2daaf Compare September 22, 2023 19:18

Pass fetch_url_allowlist from DRS to HTTP source

6341c7c

mvdbeek merged commit 73ad4f4 into galaxyproject:release_23.1 Sep 24, 2023
37 of 38 checks passed

dannon modified the milestones: 23.2, 23.1 Sep 25, 2023