-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate collection elements
store to Pinia
#16725
Migrate collection elements
store to Pinia
#16725
Conversation
collection elements
store to Pinia
Convert to composition API + Typescript
0aede14
to
8470256
Compare
I think this is ready for review. I will continue with the collection scrolling improvements in a different PR. |
Hmm, test failures seem related... Investigating... 🔎 |
It always returns a detailed view of the collection since there are no serialization parameters in this route to change the view.
The DCObject information does not contain enough information (like `element_count` or `collection_id`) to handle the sub-collection elements navigation downstream.
92f7a7d
to
c029991
Compare
None is not a valid extension and it seems to return this when you have a collection containing other sub-collections
25c3c6c
to
4b2e2be
Compare
I think I found out what was causing these Framework test failures after fixing the response type annotation for The issue was that the validation for |
I'm not sure what is going on with Can someone try to run it and check? |
Test passes consistently locally. Seems to be unrelated to this PR. PR looks good to me, works fine, is definitely a step into the right direction. Thank you @davelopez. |
Migrates the
collectionElementsStore
from Vuex to Pinia and modernizes the CollectionPanel component. Also tightens the type annotations in the related API schema models.TODO
BONUS
How to test the changes?
License