Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release_23.1 into dev #16691

Merged
merged 27 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
67382fc
Log in or register standardization -- we missed this one I guess?
dannon Aug 24, 2023
5444808
Use bsvue checkbox on register form for correct blocking/styling.
dannon Sep 6, 2023
94f8a5c
Allow rich contents for registration warning message -- this is save …
dannon Sep 6, 2023
b10e902
Show more of terms on larger screen without chopping to 1x1, add scro…
dannon Sep 6, 2023
a6b2b2f
Add eslint bypass for safe v-html
dannon Sep 6, 2023
9e30c70
Add slight border to scroll indicator for visibility
dannon Sep 6, 2023
263fac2
Adjust checkbox label for mailing list subscription
dannon Sep 6, 2023
3c07df1
Minor login -> Log in tweaks
dannon Sep 7, 2023
0cd7a0c
Update galaxyproject/charts utilizing visualizations to match the lat…
dannon Sep 11, 2023
8c5ac57
Fix incorrect ``output_fnames`` calculation in pulsar job runner
mvdbeek Sep 12, 2023
90c8438
Fix and extend extended metadata outputs to working directory tests
mvdbeek Sep 12, 2023
6210267
Set up output_fnames also with ``use_metadata_binary``
mvdbeek Sep 12, 2023
af9a0f3
Merge pull request #16652 from dannon/login-fixes
dannon Sep 12, 2023
c26e5b6
Only show 'edit' on published pages when viewer is the owner. Shared
dannon Sep 12, 2023
8ae0b92
Always reset external filename
mvdbeek Sep 12, 2023
9961ec3
Fix pulsar path rewrite for set_metadata
mvdbeek Sep 12, 2023
01d4d43
Drop unnecessary getsize guard
mvdbeek Sep 12, 2023
7fe197b
Fix file discovery
mvdbeek Sep 12, 2023
4a46073
Fix test_pulsar_embedded_remote_metadata.py::test_tools[job_properties]
mvdbeek Sep 12, 2023
3930c6a
Fix empty file check timing
mvdbeek Sep 12, 2023
63442d1
Fix regex validation for global inline flags
mvdbeek Sep 13, 2023
ed94b91
Use --biocontainers in converter tests
mvdbeek Sep 13, 2023
5d6a11a
Merge pull request #16683 from mvdbeek/use_more_lenient_regex_library…
mvdbeek Sep 13, 2023
a7caa73
Merge pull request #16678 from mvdbeek/fix_metadata_setting
mvdbeek Sep 13, 2023
5f4107d
Merge pull request #16680 from dannon/page-owner-edit-restrict
mvdbeek Sep 13, 2023
944a610
Merge pull request #16674 from dannon/galaxy-charts-version-bump
mvdbeek Sep 13, 2023
0f2ef4d
Merge branch 'release_23.1' into dev
mvdbeek Sep 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/converter_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Run tests
run: |
mapfile -t TOOL_ARRAY < tool_list.txt
planemo test --galaxy_python_version ${{ matrix.python-version }} --galaxy_root 'galaxy root' "${TOOL_ARRAY[@]}"
planemo test --biocontainers --galaxy_python_version ${{ matrix.python-version }} --galaxy_root 'galaxy root' "${TOOL_ARRAY[@]}"
- uses: actions/upload-artifact@v3
if: failure()
with:
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/History/Modals/CopyModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<b-modal v-bind="$attrs" :title="title" title-tag="h2" v-on="$listeners">
<transition name="fade">
<b-alert v-localize :show="isAnonymous" variant="warning">
As an anonymous user, unless you login or register, you will lose your current history after copying
As an anonymous user, unless you log in or register, you will lose your current history after copying
this history. You can <a href="/user/login">log in here</a> or <a href="/user/create">register here</a>.
</b-alert>
</transition>
Expand Down
48 changes: 36 additions & 12 deletions client/src/components/Login/RegisterForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
<div class="row justify-content-md-center">
<div class="col col-lg-6">
<b-alert :show="!!registrationWarningMessage" variant="info">
{{ registrationWarningMessage }}
<!-- eslint-disable-next-line vue/no-v-html -->
<span v-html="registrationWarningMessage" />
</b-alert>
<b-alert :show="!!messageText" :variant="messageVariant">
{{ messageText }}
Expand Down Expand Up @@ -64,19 +65,18 @@
dashes ('.', '_', '-').
</b-form-text>
</b-form-group>
<b-form-group
v-if="mailingJoinAddr && serverMailConfigured"
:label="labelSubscribe"
label-for="register-form-subscribe">
<input
<b-form-group v-if="mailingJoinAddr && serverMailConfigured">
<b-form-checkbox
id="register-form-subscribe"
v-model="subscribe"
name="subscribe"
type="checkbox" />
type="checkbox">
{{ labelSubscribe }}
</b-form-checkbox>
</b-form-group>
<b-button v-localize name="create" type="submit" :disabled="disableCreate"
>Create</b-button
>
<b-button v-localize name="create" type="submit" :disabled="disableCreate">
Create
</b-button>
</b-card-body>
</b-collapse>
<b-card-footer v-if="showLoginLink">
Expand All @@ -93,8 +93,9 @@
</b-card>
</b-form>
</div>
<div v-if="termsUrl" class="col">
<b-embed type="iframe" :src="termsUrl" aspect="1by1" />
<div v-if="termsUrl" class="col position-relative embed-container">
<iframe title="terms-of-use" :src="termsUrl" frameborder="0" class="terms-iframe"></iframe>
<div v-localize class="scroll-hint">↓ Scroll to review ↓</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -204,3 +205,26 @@ export default {
},
};
</script>
<style scoped>
.embed-container {
position: relative;
}

.scroll-hint {
position: absolute;
bottom: 10px;
left: 50%;
transform: translateX(-50%);
background-color: rgba(255, 255, 255, 0.9);
border: 1px solid #ccc;
padding: 2px 5px;
border-radius: 4px;
}

.terms-iframe {
width: 100%;
height: 90vh;
border: none;
overflow-y: auto;
}
</style>
11 changes: 10 additions & 1 deletion client/src/components/PageDisplay/PageDisplay.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
:enable_beta_markdown_export="config.enable_beta_markdown_export"
:download-endpoint="stsUrl(config)"
:export-link="exportUrl"
:read-only="!userOwnsPage"
@onEdit="onEdit" />
<PageHtml v-else :page="page" />
</div>
Expand All @@ -17,7 +18,10 @@
</template>

<script>
import { storeToRefs } from "pinia";

import { useConfig } from "@/composables/config";
import { useUserStore } from "@/stores/userStore";
import { withPrefix } from "@/utils/redirect";
import { urlData } from "@/utils/url";

Expand All @@ -39,14 +43,19 @@ export default {
},
setup() {
const { config, isConfigLoaded } = useConfig(true);
return { config, isConfigLoaded };
const userStore = useUserStore();
const { currentUser } = storeToRefs(userStore);
return { config, currentUser, isConfigLoaded };
},
data() {
return {
page: {},
};
},
computed: {
userOwnsPage() {
return this.currentUser.username === this.page.username;
},
dataUrl() {
return `/api/pages/${this.pageId}`;
},
Expand Down
2 changes: 1 addition & 1 deletion client/src/entry/analysis/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export function fetchMenu(options = {}) {
if (options.allow_user_creation) {
userTab = {
id: "user",
title: _l("Login or Register"),
title: _l("Log in or Register"),
cls: "loggedout-only",
url: "/login",
tooltip: _l("Log in or register a new account"),
Expand Down
2 changes: 1 addition & 1 deletion client/src/nls/de/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ define({
User: "Benutzer",
Login: "Anmeldung",
Register: "Neu registrieren",
"Login or Register": "Einloggen oder Registrieren",
"Log in or Register": "Einloggen oder Registrieren",
"Signed in as": "Angemeldet als",
Preferences: "Präferenzen",
"Custom Builds": "Custom Builds",
Expand Down
2 changes: 1 addition & 1 deletion client/src/nls/es/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ define({

Register: "Registro",

"Login or Register": "Iniciar sesión o Registrarse",
"Log in or Register": "Iniciar sesión o Registrarse",
"Subscribe to mailing list": false,
"Already have an account?": false,
"Log in here.": false,
Expand Down
2 changes: 1 addition & 1 deletion client/src/nls/fr/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ define({
User: "Utilisateur",
Login: "Authentification",
Register: "Enregistrement",
"Login or Register": "Authentification et Enregistrement",
"Log in or Register": "Authentification et Enregistrement",
"Signed in as": "Authentifié en tant que",
Preferences: "Préférences",
"Custom Builds": "Mes génomes Builds de référence",
Expand Down
2 changes: 1 addition & 1 deletion client/src/nls/ja/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ define({
User: "ユーザー",
Login: "ログイン",
Register: "登録",
"Login or Register": "ログイン/登録",
"Log in or Register": "ログイン/登録",
Preferences: "設定",
"Custom Builds": "カスタムビルド",
Logout: "ログアウト",
Expand Down
2 changes: 1 addition & 1 deletion client/src/nls/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ define({
User: false,
Login: false,
Register: false,
"Login or Register": false,
"Log in or Register": false,
"Signed in as": false,
Preferences: false,
"Custom Builds": false,
Expand Down
2 changes: 1 addition & 1 deletion client/src/nls/zh/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ define({
User: "账号管理",
Login: "登陆",
Register: "注册",
"Login or Register": "注册登陆",
"Log in or Register": "注册登陆",
"Signed in as": "您已登陆为",
Preferences: "用户偏好性",
"Custom Builds": "自定义构建集",
Expand Down
4 changes: 2 additions & 2 deletions config/plugins/visualizations/example/package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "visualization",
"version": "0.1.0",
"version": "0.2.0",
"keywords": [
"galaxy",
"visualization"
],
"license": "AFL-3.0",
"dependencies": {
"@galaxyproject/charts": "^0.0.6",
"@galaxyproject/charts": "^0.1.0",
"babel-preset-env": "^1.6.1",
"backbone": "^1.3.3",
"bootstrap": "^3.3.7",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "visualization",
"version": "0.1.0",
"version": "0.2.0",
"keywords": [
"galaxy",
"visualization"
],
"license": "AFL-3.0",
"dependencies": {
"@galaxyproject/charts": "^0.0.6",
"@galaxyproject/charts": "^0.1.0",
"babel-preset-env": "^1.6.1",
"backbone": "^1.4.0",
"bootstrap": "^3.3.7",
Expand Down
4 changes: 2 additions & 2 deletions config/plugins/visualizations/jqplot/jqplot_bar/package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "visualization",
"version": "0.1.0",
"version": "0.2.0",
"keywords": [
"galaxy",
"visualization"
],
"license": "AFL-3.0",
"dependencies": {
"@galaxyproject/charts": "^0.0.6",
"@galaxyproject/charts": "^0.1.0",
"babel-preset-env": "^1.6.1",
"backbone": "^1.3.3",
"bootstrap": "^3.3.7",
Expand Down
4 changes: 2 additions & 2 deletions config/plugins/visualizations/nvd3/nvd3_bar/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nvd3",
"version": "0.1.0",
"version": "0.2.0",
"description": "NVD3 visualization plugin.",
"keywords": [
"galaxy",
Expand All @@ -9,7 +9,7 @@
],
"license": "AFL-3.0",
"dependencies": {
"@galaxyproject/charts": "^0.0.6",
"@galaxyproject/charts": "^0.1.0",
"babel-preset-env": "^1.6.1",
"backbone": "^1.3.3",
"bootstrap": "^3.3.7",
Expand Down
4 changes: 2 additions & 2 deletions config/plugins/visualizations/venn/package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "visualization",
"version": "0.1.0",
"version": "0.2.0",
"keywords": [
"galaxy",
"visualization"
],
"license": "AFL-3.0",
"dependencies": {
"@galaxyproject/charts": "^0.0.6",
"@galaxyproject/charts": "^0.1.0",
"babel-preset-env": "^1.6.1",
"backbone": "^1.3.3",
"bootstrap": "^3.3.7",
Expand Down
1 change: 1 addition & 0 deletions lib/galaxy/dependencies/pinned-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ pyyaml==6.0.1 ; python_version >= "3.7" and python_version < "3.12"
pyzmq==25.1.1 ; python_version >= "3.7" and python_version < "3.12"
rdflib==6.2.0 ; python_version >= "3.7" and python_version < "3.12"
refgenconf==0.12.2 ; python_version >= "3.7" and python_version < "3.12"
regex==2023.8.8 ; python_version >= "3.7" and python_version < "3.12"
repoze-lru==0.7 ; python_version >= "3.7" and python_version < "3.12"
requests-oauthlib==1.3.1 ; python_version >= "3.7" and python_version < "3.12"
requests-toolbelt==1.0.0 ; python_version >= "3.7" and python_version < "3.12"
Expand Down
Loading