Change Sentry error reporting plug-in #16686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the tool's name (tool id without version) as issue title. This should merge reports for all versions of a tool. Report any other extra information in the contexts. - Submit Galaxy Job error reports with level "error" rather than "info". - Do not include the user's email in the "job" context. It is redundant because it was already being included in the "user" context. - Move the user's feedback message to a new "feedback" context. - Report the user's information as actual Sentry user information rather than a "user" context. - Change existing tags. Use "tool" for `job.tool_id`, `tool.name` for the tool's name (tool id without version) and `tool.version` for the tool's version. - Add a tag informing of whether the user provided feedback or not so that intentional bug reports can be quickly found.
The request context's "url" field is filled with the text "*deprecated attribute, URL not filled in by server*".
|
ping @neoformit |
|
Do I have to do anything extra? Or can the PR be merged? |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16637.
Use the tool's name (tool id without version) as issue title. This should merge reports for all versions of a tool. Report any other extra information in the contexts.
Submit Galaxy Job error reports with level "error" rather than "info".
Do not include the user's email in the "job" context. It is redundant because it was already being included in the "user" context.
Move the user's feedback message to a new "feedback" context.
Report the user's information as actual Sentry user information rather than a "user" context.
Remove the "request" context. The request context's "url" field is otherwise filled with the text "deprecated attribute, URL not filled in by server".
Change existing tags. Use "tool" for
job.tool_id,tool.namefor the tool's name (tool id without version) andtool.versionfor the tool's version.Add a tag informing of whether the user provided feedback or not so that intentional bug reports can be quickly found.
I tested this in a local Galaxy + Sentry deployment. It looks as shown below.
How to test the changes?
License