Refactor models enums to eliminate schema dependency on model layer. #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a piece that is needed to create a schema package - which I would really like to have around for galaxyproject#15639 and to in general write higher-level API tests.
jmchilton
added
kind/refactoring
davelopez
approved these changes
May 13, 2023
|
Restarted the 2 failing tests and now everything is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a piece that is needed to create a schema package - which is implemented in #15639 and I would like to have available in general to write higher-level API tests that do more validation with less code but without bringing in heavy dependencies on the model layer either.
How to test the changes?
(Select all options that apply)
License