-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mamba instead if --solver libmamba to create conda environemnts #15984
Conversation
I would probably go with mamba instead of libmamba for that reason. |
What's the status here ? Seems fine to me |
Guess I should revert 141bb16 .. before we used mamba for containers and libmamba for conda envs .. with the current state we switched the inconsistency. By reverting we would use mamba for both. |
This reverts commit 141bb16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several places in this file that assume you are using conda and not mamba (e.g. can_install_conda()
), which would need to be carefully checked.
I am bit confused by the fact that the issue you were originally trying to solve was happening when using mamba and not conda, so why switch to mamba?
For consistency with bioconda: #15984 |
that is to allow for mamba
|
Then we can close this one. Thanks for the update. |
Thanks @bernt-matthias. Things are moving fast, soon people will use pixi for conda packages ... ;-) |
For container building. In order to be consistent with what is done when building conda environments (non-containerized).
Background: I just stumbled over this when I tried to debug a multi-package-container that got a super old samtools installed:
mamba create --override-channels --channel conda-forge --channel bioconda --channel defaults --name TEST python samtools
will install samtools 1.6 .. if you just switch the order of the requirements the most recent one is installed.I asked on the conda libmamba gitter and learned that using
mamba
and--solver libmamba
is quite different. Here is a quote from the conversation:Both rely on the same libraries (libmambapy->libmamba->libsolv), but the integration with conda is done differently:
So I think we should definitely be consistent.
libmamba
seems a bit more conservative so I went for this one for now (annoyingly I immediately observed an unresolvalble environment withlibmamba
that could be resolved withmamba
).Problems/discussion:
mamba
.. so maybemamba
would be a better option in terms of consistency?How to test the changes?
(Select all options that apply)
License